Exclude self from static cluster connectors #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static-connectors of a cluster should not contain this brokers' own connector as it will happily connect to itself and thus not properly participate in the cluster. Also added an option to configure allow-direct-connections-only and set it to false. This would allow a cluster to become dynamic using an initial static list.
This will verify if a cluster config for a live-only cluster is valid.
|
https://forge.puppet.com/modules/jonnyhoeven/activemq/readme 2.0.1 is published with these changes |
|
@jonnyhoeven Oh, is this a new way of saying "please merge this PR faster"? 😄 |
fraenki
approved these changes
Nov 28, 2023
|
@elmuerte Merged, thanks! |
Wouldn't dare to do that. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static-connectors of a cluster should not contain this brokers' own connector as it will happily connect to itself and thus not properly participate in the cluster.
Also added an option to configure allow-direct-connections-only and set it to false. This would allow a cluster to become dynamic using an initial static list.
I extended the existing acceptance test to verify the new behavior.